Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTE-573] Remove experimental warning log for OE #1971

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[OTE-573] Remove experimental warning log for OE #1971

merged 1 commit into from
Jul 29, 2024

Conversation

teddyding
Copy link
Contributor

@teddyding teddyding commented Jul 26, 2024 •
edited by coderabbitai bot
Loading

Changelist

Remove experimental warning log for OE

Test Plan

No-op change

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features
    • Optimistic execution is now enabled without the previous warning, indicating improved stability and readiness for production use.
    • Added an informational log to confirm the activation of optimistic execution.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 26, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes focus on the New function within the protocol/app/app.go file, adjusting the handling of the OptimisticExecutionEnabled flag. The prior warning regarding its experimental status has been removed, replaced by an informational log indicating optimistic execution is now actively enabled. This shift signifies a more favorable evaluation of the feature, suggesting it may be approaching production readiness without altering the underlying logic.

Changes

Files Change Summary
protocol/app/app.go Removed warning log for OptimisticExecutionEnabled, added informational log confirming its activation.

Poem

🐇 In the code, a change we see,
Optimistic flags, now bold and free!
Warnings gone, a brighter view,
Production dreams are coming true.
Hops of joy, let features play,
Here’s to progress, hip-hip-hooray! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@teddyding teddyding changed the title Remove experimental warning log for OE [OTE-573] Remove experimental warning log for OE Jul 26, 2024
@linear Linear
Copy link

linear bot commented Jul 26, 2024

OTE-573 Remove warning log when feature fully ready

@teddyding teddyding marked this pull request as ready for review July 29, 2024 16:25
@teddyding teddyding merged commit ac1e4f7 into main Jul 29, 2024
18 checks passed
@teddyding teddyding deleted the td/oe-exp-log branch July 29, 2024 16:25
@teddyding
Copy link
Contributor Author

@Mergifyio backport release/protocol/v6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 29, 2024 •
edited
Loading

backport release/protocol/v6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 29, 2024
@teddyding @mergify
[OTE-573] Remove experimental warning log for OE (#1971)
62b34f1 
(cherry picked from commit ac1e4f7)
mergify bot pushed a commit that referenced this pull request Jul 29, 2024
@teddyding @mergify
[OTE-573] Remove experimental warning log for OE (#1971)
9f0a53a 
(cherry picked from commit ac1e4f7)

# Conflicts:
#	protocol/app/app.go
mergify bot pushed a commit that referenced this pull request Jul 29, 2024
@teddyding @mergify
[OTE-573] Remove experimental warning log for OE (#1971)
5a6f9ae 
(cherry picked from commit ac1e4f7)

# Conflicts:
#	protocol/app/app.go
This was referenced Jul 29, 2024
Open
Open
Open
teddyding added a commit that referenced this pull request Aug 7, 2024
@teddyding
[OTE-573] Remove experimental warning log for OE (#1971)
4f720b3
teddyding added a commit that referenced this pull request Aug 8, 2024
@teddyding
[OTE-573] Remove experimental warning log for OE (#1971)
c40a010
teddyding added a commit that referenced this pull request Aug 8, 2024
@teddyding
[OTE-573] Remove experimental warning log for OE (#1971)
888254e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayy04 jayy04 jayy04 approved these changes

Assignees
No one assigned
Labels
backport/protocol/v5.1.x backport/protocol/v5.2.x feature:optimistic_execution protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teddyding @jayy04